Fix parsing for .properties files with -
in path
#975
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test that repros the problem in #974 and fixes it, at least for this specific filetype. The fix just involves changing the maximum file extension length for one of the regexes. The same problem would still happen to files with longer extensions.
There's probably a small tradeoff between performance and file extension length, and there will probably always be someone out there who wants to use even longer file extensions. But I think
.properties
is worth supporting - it's a common enough filetype to have its own Wikipedia article.