🐛 --file-transformation is applied to hunk header but not diff header

[salmankhilji]

--file-transformation does not seem to do anything. Perhaps, I am not sure how to use it properly? Maybe, the fix is to elaborate with a working example within the documentation!

Repro Steps

1. seq 5 >foo

2. seq 8 >bar

3. Run delta like this:

   $ delta --width=80 -s --hunk-header-style=omit --file-style=none --file-transformation='s,foo,bar,' foo bar
   
   foo ⟶   bar
   ────────────────────────────────────────────────────────────────────────────────
   
   │  3 │3                                 │  3 │3
   │  4 │4                                 │  4 │4
   │  5 │5                                 │  5 │5
   │    │                                  │  6 │6
   │    │                                  │  7 │7
   │    │                                  │  8 │8
   precor@byteevo-scm:~/Scratch$ 
   

Observed Behavior

Observe the following within the header:

foo ⟶   bar

Expected Behavior

If the sed like expression worked, then I would expect to see:

bar ⟶   bar

Additional Context

#997

$ delta --version
delta 0.12.1

[dandavison]

Hi @salmankhilji, thanks -- you're right, there's a bug. It is currently applied to the file name in the hunk header, but not the "main" file name in the diff header. There was no good reason for that: I made the option for myself and I personally don't use the main diff header (my config is below)! I've pushed a fix in #1012 .

    file-style = omit blue
    hunk-header-style = file line-number syntax