Replace usage of the atty crate with std::io::IsTerminal trait (#…

…1465)

Rust 1.70 stabilized the `IsTerminal` trait and the newest version of
`grep-cli` crate depending on it, makes it possible to remove the
unmaintained `atty` crate from the build.

```
Crate:     atty
Version:   0.2.14
Warning:   unsound
Title:     Potential unaligned read
Date:      2021-07-04
ID:        RUSTSEC-2021-0145
URL:       https://rustsec.org/advisories/RUSTSEC-2021-0145
```

Cargo.toml

@@ -21,15 +21,14 @@ chrono-humanize = "0.2.2"
 ansi_colours = "1.2.1"
 ansi_term = "0.12.1"
 anyhow = "1.0.70"
-atty = "0.2.14"
 bitflags = "2.2.1"
 box_drawing = "0.1.2"
 bytelines = "=2.2.2" # Pin version until its tokio and futures dependencies are optional.
 clap = { version = "4.1.11", features = ["derive", "help", "usage", "error-context", "wrap_help"] }
 console = "0.15.0"
 ctrlc = "3.2.5"
 dirs = "5.0.1"
-grep-cli = "0.1.7"
+grep-cli = "0.1.8"
 itertools = "0.10.5"
 lazy_static = "1.4"
 palette = "0.7.2"

src/delta.rs

@@ -1,7 +1,6 @@
 use std::borrow::Cow;
 use std::collections::HashMap;
-use std::io::BufRead;
-use std::io::Write;
+use std::io::{self, BufRead, IsTerminal, Write};
 
 use bytelines::ByteLines;
 
@@ -260,7 +259,7 @@ impl<'a> StateMachine<'a> {
 /// If output is going to a tty, emit hyperlinks if requested.
 // Although raw output should basically be emitted unaltered, we do this.
 pub fn format_raw_line<'a>(line: &'a str, config: &Config) -> Cow<'a, str> {
-    if config.hyperlinks && atty::is(atty::Stream::Stdout) {
+    if config.hyperlinks && io::stdout().is_terminal() {
         features::hyperlinks::format_commit_line_with_osc8_commit_hyperlink(line, config)
     } else {
         Cow::from(line)

src/main.rs

@@ -24,7 +24,7 @@ mod subcommands;
 
 mod tests;
 
-use std::io::{self, ErrorKind};
+use std::io::{self, ErrorKind, IsTerminal};
 use std::process;
 
 use bytelines::ByteLinesReader;
@@ -130,7 +130,7 @@ fn run_app() -> std::io::Result<i32> {
         return Ok(exit_code);
     }
 
-    if atty::is(atty::Stream::Stdin) {
+    if io::stdin().is_terminal() {
         eprintln!(
             "\
     The main way to use delta is to configure it as the pager for git: \

src/subcommands/list_syntax_themes.rs

@@ -1,4 +1,4 @@
-use std::io::{self, Write};
+use std::io::{self, IsTerminal, Write};
 
 use itertools::Itertools;
 
@@ -8,7 +8,7 @@ use crate::{options::theme::is_light_syntax_theme, utils};
 pub fn list_syntax_themes() -> std::io::Result<()> {
     let stdout = io::stdout();
     let mut stdout = stdout.lock();
-    if atty::is(atty::Stream::Stdout) {
+    if stdout.is_terminal() {
         _list_syntax_themes_for_humans(&mut stdout)
     } else {
         _list_syntax_themes_for_machines(&mut stdout)

src/subcommands/show_syntax_themes.rs

@@ -6,7 +6,7 @@ use crate::options::theme::is_light_syntax_theme;
 use crate::utils;
 use crate::utils::bat::output::{OutputType, PagingMode};
 use clap::Parser;
-use std::io::{self, ErrorKind, Read, Write};
+use std::io::{self, ErrorKind, IsTerminal, Read, Write};
 
 #[cfg(not(tarpaulin_include))]
 pub fn show_syntax_themes() -> std::io::Result<()> {
@@ -21,7 +21,7 @@ pub fn show_syntax_themes() -> std::io::Result<()> {
     .unwrap();
     let mut writer = output_type.handle().unwrap();
 
-    let stdin_data = if !atty::is(atty::Stream::Stdin) {
+    let stdin_data = if !io::stdin().is_terminal() {
         let mut buf = Vec::new();
         io::stdin().lock().read_to_end(&mut buf)?;
         if !buf.is_empty() {

src/subcommands/show_themes.rs

@@ -1,4 +1,4 @@
-use std::io::{self, ErrorKind, Read};
+use std::io::{self, ErrorKind, IsTerminal, Read};
 
 use crate::cli;
 use crate::config;
@@ -17,7 +17,7 @@ pub fn show_themes(dark: bool, light: bool, computed_theme_is_light: bool) -> st
 
     let mut input = DIFF.to_vec();
 
-    if !atty::is(atty::Stream::Stdin) {
+    if !io::stdin().is_terminal() {
         let mut buf = Vec::new();
         io::stdin().lock().read_to_end(&mut buf)?;
         if !buf.is_empty() {