early continue

danbi2990 · Oct 24, 2023 · 0e6f48a · 0e6f48a
1 parent 85166ca
commit 0e6f48a
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/crates/ruff_linter/src/rules/pylint/rules/redefined_argument_from_local.rs b/crates/ruff_linter/src/rules/pylint/rules/redefined_argument_from_local.rs
@@ -111,7 +111,10 @@ pub(crate) fn redefined_argument_from_local(checker: &mut Checker, stmt: &Stmt)
     loop {
         if let ScopeKind::Function(ast::StmtFunctionDef { parameters, .. }) = scope.kind {
             for (name, range) in visitor.names() {
-                if parameters.includes(name) && !already_added.contains(&range) {
+                if already_added.contains(&range) {
+                    continue;
+                }
+                if parameters.includes(name) {
                     dianostics.push(Diagnostic::new(
                         RedefinedArgumentFromLocal {
                             name: name.to_string(),