[pom] Remove oss-parent, update libs, and add release/enforcer plugin #1228
Conversation
rest was already in here from really old obsolete oss parent.
| @@ -1,18 +1,12 @@ | |||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> | |||
There was a problem hiding this comment.
Add missing xml indicator and add proper maven secure xsd location.
|
|
||
| <!-- 'oss-parent' should not be used, it was deprecated years ago --> |
There was a problem hiding this comment.
Remove obsolete oss parent which was almost entirely overridden.
|
|
||
| <groupId>net.masterthought</groupId> | ||
| <artifactId>cucumber-reporting</artifactId> | ||
| <packaging>jar</packaging> |
There was a problem hiding this comment.
jar is the default, it is not necessary.
| @@ -25,7 +19,10 @@ | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <project.build.resourceEncoding>UTF-8</project.build.resourceEncoding> | |||
|
|
|||
| <byte-buddy.version>1.15.10</byte-buddy.version> | |||
| <!-- Maven minimum version --> | |||
There was a problem hiding this comment.
Set default maven version 3.6.3 as maven has stated all older versions are obsolete. This only matters for the build, nothing else, technically it should be 3.9.9 but keeping it low as not sure what other contributors are using currently. This comes from the original oss parent that was dealing with maven 2 versions.
| @@ -225,6 +222,35 @@ | |||
| </execution> | |||
| </executions> | |||
| </plugin> | |||
| <plugin> | |||
There was a problem hiding this comment.
Add enforcer to force maven 3.6.3 or better to build. This is adjusted from the original oss parent.
| </executions> | ||
| </plugin> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> |
There was a problem hiding this comment.
Added release plugin from original oss parent but replaced attributes. The first one makes it not mess with the second line of this file. The second one ensures it is generating sha's properly on release through sha-512.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1228 +/- ##
=========================================
Coverage 98.27% 98.27%
- Complexity 565 567 +2
=========================================
Files 55 55
Lines 1215 1218 +3
Branches 105 105
=========================================
+ Hits 1194 1197 +3
Misses 10 10
Partials 11 11 ☔ View full report in Codecov by Sentry. |
|
Hi @damianszczepanik, this pull request gets the project off long deprecated oss-parent, I also took the time to update various libraries that were out of date. Most of the original oss-parent was already overridden here. Only 2 plugins were not. I'm currently using maven 4.0.0-rc-2. The build will fail using such old plugins from that oss parent. After this update, the build then works for maven 4 as well. Here is a snippet of my output to show that. |
|
@hazendaz thank you for this change! |
rest was already in here from really old obsolete oss parent.