-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the visibility of the reportParser field #1216
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8316197
Change the visibility of the reportParser field:
jit3pam c5062c5
Merge branch 'master' into master
jit3pam 61d3750
Merge branch 'master' into master
jit3pam af2ad6b
Revert "Change the visibility of the reportParser field:"
jit3pam 4da9a7e
use getter and setters for reportParser field in ReportBuilder and ad…
jit3pam 9113f55
fix indentation in the signatures for the new constructor in ReportBu…
jit3pam cd710c2
remove the second constructor
jit3pam 485f9ff
keep only relevant lines in the unit test
jit3pam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,6 +62,23 @@ void ReportBuilder_storesFilesAndConfiguration() { | |
assertThat(assignedConfiguration).isSameAs(configuration); | ||
} | ||
|
||
@Test | ||
void ReportBuilder_setsAndGetsCustomReportParser(){ | ||
// given | ||
final List<String> jsonFiles = new ArrayList<>(); | ||
final Configuration configuration = new Configuration(null, null); | ||
final ReportParser reportParser = new ReportParser(configuration); | ||
|
||
// when | ||
ReportBuilder builder = new ReportBuilder(jsonFiles, configuration); | ||
builder.setReportParser(reportParser); | ||
|
||
// then | ||
ReportParser assignedReportParser = Whitebox.getInternalState(builder, "reportParser"); | ||
|
||
assertThat(assignedReportParser).isSameAs(builder.getReportParser()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. could be just There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Duly noted Damian! Thank you. |
||
} | ||
|
||
@Test | ||
void generateReports_GeneratesPages() { | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, this is what I expect o extend