Add test for getExtension method in Embedding class #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1134 +/- ##
=========================================
Coverage 97.11% 97.11%
Complexity 555 555
=========================================
Files 55 55
Lines 1212 1212
Branches 106 106
=========================================
Hits 1177 1177
Misses 20 20
Partials 15 15 ☔ View full report in Codecov by Sentry. |
- Introduce a new test case to ensure correct behavior of the getExtension method. - Enhance coverage for the Embedding class, specifically validating its handling of unknown MIME types.
damianszczepanik
force-pushed
the
enhancement/add-embedding-test
branch
from
de6fe84 to
410833f
Compare
|
Nice test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This pull request introduces a new test case in the
EmbeddingTestclass, specifically in thegetExtensionmethod. The test, namedgetExtension_UsesExtensionFromNameWhenMIMETypeIsUnknown, verifies that the method correctly retrieves the file extension from the name when the MIME type is unknown. This improvement makes sure our code handles unknown file types more effectively and adds to the overall coverage of our code tests.Your review of the changes is appreciated. Thank you!