Add test case for getEmbeddingDirectory in ConfigurationTest #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new test case to ensure that the getEmbeddingDirectory method in the Configuration class correctly creates the embedding directory path.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1132 +/- ##
============================================
+ Coverage 97.11% 98.27% +1.15%
- Complexity 555 568 +13
============================================
Files 55 55
Lines 1212 1215 +3
Branches 106 105 -1
============================================
+ Hits 1177 1194 +17
+ Misses 20 10 -10
+ Partials 15 11 -4 ☔ View full report in Codecov by Sentry. |
| File reportDirectory = new File("target"); | ||
| Configuration configuration = new Configuration(reportDirectory, "myProject"); | ||
|
|
||
| String expectedPath = new File(reportDirectory, "cucumber-html-reports" + File.separatorChar + "embeddings").getAbsolutePath(); |
There was a problem hiding this comment.
replace with ReportBuilder.BASE_DIRECTORY
There was a problem hiding this comment.
and Configuration.EMBEDDINGS_DIRECTORY
damianszczepanik
requested changes
Dec 26, 2023
| String expectedPath = new File(reportDirectory, "cucumber-html-reports" + File.separatorChar + "embeddings").getAbsolutePath(); | ||
|
|
||
| // Act | ||
| File embeddingDirectory = configuration.getEmbeddingDirectory(); |
There was a problem hiding this comment.
based on the method name - this is not 'act'
Refactor the getEmbeddingDirectory test to improve readability and use constants ReportBuilder.BASE_DIRECTORY and configuration.getEmbeddingsDirectory for better maintainability. The test now follows the given-when-then structure, and the method name has been adjusted for clarity.
damianszczepanik
requested changes
Jan 3, 2024
| // given | ||
| File reportDirectory = new File("target"); | ||
| Configuration configuration = new Configuration(reportDirectory, "myProject"); | ||
| String expectedPath = new File(reportDirectory, ReportBuilder.BASE_DIRECTORY + |
There was a problem hiding this comment.
I think you misunderstand how File works. It represents the abstract path it does not do what you write in method name above
https://docs.oracle.com/javase/8/docs/api/java/io/File.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This pull request introduces a new test case in the
ConfigurationTestclass, validating thegetEmbeddingDirectorymethod. The test ensures that the method correctly creates the embedding directory path. This addition enhances the code coverage of the Configuration class.Please review the changes. Thank you!