Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill the process if it's exceeded it's allotted time to shutdown #97

Merged
merged 3 commits into from
Sep 24, 2020
Merged

Kill the process if it's exceeded it's allotted time to shutdown #97

merged 3 commits into from
Sep 24, 2020

Conversation

pgermishuys
Copy link
Collaborator

Kill the process if it's exceeded it's allotted time to shutdown.

  • The helper processes were also not compiling due to the logger factory change, this has now been fixed.
  • Introduced the ability to ignore the shutdown signal in NonTerminatingProcess

@pgermishuys
Fix HelperProcesses by providing LoggerFactory parameter
8cd0464
@pgermishuys
Introduce ability to ignore shutdown signal
ba18cd7
@pgermishuys
Kill the process if it doesnt exit within timeout
40d59df 
Since the supervisor is the owner of the process, the supervisor will
give the process a time within the application can gracefully shutdown
once informed to do so. If the process does not exit in the provided
timeout, the supervisor will kill the process.
@pgermishuys pgermishuys requested a review from damianh September 24, 2020 17:17
@pgermishuys pgermishuys changed the title Kill on timeout Kill the process if it's exceeded it's allotted time to shutdown Sep 24, 2020
@damianh damianh merged commit db0712a into master Sep 24, 2020
@damianh damianh deleted the kill-on-timeout branch September 24, 2020 17:22
@damianh damianh added this to the v2.0.1 milestone Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianh damianh damianh approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@pgermishuys @damianh