fix configuration of appname width #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
We avoid propagating the negation and instead use a meaningful name as "dest", set the action to "store_false" and the default to True. Also the "dest" for "--no-database" is changed to "database" for consistency with other options. When building the Flag value, in Flag.load(), we now follow the order of options definition. Finally, we define a flag() helper to factor out the common definition pattern of these options.
There was a discrepancy in column names and configuration options. We now use configuration option names when looking up in the configuration to determine if a column has a custom width defined.
We move the many 'ifs' within the add_column() helper, which makes it possible to catch unhandled configuration entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #415