UI rewrite #145
Merged
UI rewrite #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlax
force-pushed
the
ui-rewrite
branch
5 times, most recently
from
aaac543 to
ebf88be
Compare
dlax
force-pushed
the
ui-rewrite
branch
11 times, most recently
from
dc98584 to
5a55b84
Compare
dlax
force-pushed
the
ui-rewrite
branch
4 times, most recently
from
2cf01f7 to
2b63a21
Compare
Since psutil_proc attribute cannot be deserialized, we make it optional and check for this in update_processes_local().
Test data was obtained from a live session of pg_activity in local mode.
Copy/adjusted from UI.get_indent().
The ActivityBW is slightly different from Activity.
So that this matches ActivityProcess's duration field name.
|
Last commits add support for the "tag" action in interactive mode. |
This way, we filter out keys that would not make sense when respective column is not shown.
We rework the column width calculation in render_footer() and possible crop the text it it would exceed terminal width.
We now print shortened lines in limit() decorator, using the added shorten() helper function. The width of lines can be controlled as a view parameter (useful in tests) and defaults to terminal width.
Following up UI rewrite.
This reverts commit 8ea35b8 because it seems more natural to have the 'q' not to exit the program when in help menu.
Follow-up on 72dfcb1, but missed because of NORMALIZE_WHITESPACE doctest flag.
This would happen *normally* upon 'cancel' or 'terminate' actions.
In order to hopefully resolve flakyness in CI.
|
Huge work @dlax! I will give it a try next week. Many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR concerns the rewrite of the UI part of
pg_activityusing blessed. It also includes packaging improvements and introduces a modern QA setup.