Removed "nightly" from default features #34
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using this crate and was surprised to have a compile error when switching to "stable". The error came from
subtle
trying to use a#![feature(...)]
gate. I spent some time tracking down what was usingsubtle
with the "nightly" feature flag set. I checkedcurve25519-dalek
anded25519-dalek
and neither of them set "nightly" by default. I found it a bit surprising, then, thatx25519-dalek
was the culprit.So, in keeping with
curve25519-dalek
,ed25519-dalek
,subtle
, andzkp
, I think this should compile by default on "stable".