-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invisible icons #59
Comments
Looking at the errors, I think this might come from some inconsistency with the relative paths used in
So it either should be |
Howdy, thanks for reaching out! It is odd why you're seeing errors for just those three assets. Especially as your screenshots show those icons have loaded. You should look in this file for the image URLs that are used as this is the CSS bundle created by webpack... https://github.com/daledavies/jump/blob/main/jumpapp/assets/css/styles.00c4db10d75e0c01f6eb.min.css The issue shown in your screenshots however seems like jump isn't getting the response it expects from the Open Weather Map API. Could you post any errors you see in your browser's javascript console? |
I've actually identified a fix for the issue I think might be happening, so even if jump gets an error from open weather it will still finish loading, this will be included in the next release. But I'm curious as to whether this is the problem you're facing and seeing if there are any errors in the javascript console will help identify that 😀 |
... Interesting. The console indeed shows an error related to OpenWeather:
I've just I've also checked the css file, and it seems that the links are |
i had the same issue with the icons not showing, but they are there because when i hover over the area that they are supposed to be. I can help with any information that you need to track the issue |
This is usually because of an issue with either your OWM API key or a problem with the container being able to connect to it. Can you provide a screenshot of the javascript console from devtools? |
Note I do not think there is a CSS issue |
@daledavies in my case was the LATLONG variable, i put just like google maps give it to me 20.456600, -97.987094. Notice the space after the comma, i delete that space and now everything works! |
Awesome, glad you got it working. Thanks for reaching out 😀 |
Following; I've just started using this dashboard and I also get invisible icons sometimes. |
bump, same issue here |
For all the interested people here is what was my original problem: the container was not able to resolve hostnames at all due to DNS misconfiguration. This is why I had a resolution error that went away after It looks like any network issue(eg. resolution problem, API problem, etc) would lead to invisible icons... |
@Toucani This makes a lot of sense; I just fixed DNS issues, so that could have been it. |
Ending up resolving it after removing the following lines from the environment section of the
|
@mynameistito That's fine if you don't want weather on the page; otherwise, you should replace those with your own key and position. |
Yes, that is true @cinderblockgames but what's the fix 🤔 I've even added my own key and |
Hi everyone, thank you for keeping up the discussion on this issue. Just wanted to let you know I have not disappeared but I did need to take a little break. Although there are some improvements I do want to make that will stop the icons from being invisible if there is an error from the open weather API, debugging what is actually going on with the API call is difficult for me to do if I can't recreate it. There should be some error logged in either the devtools console or docker logs that will indicate an API error, can you check to see? |
Same issue. Solved by removing the DEFAULT added OWMAPIKEY and LATLONG entries from sites/sites_json, removing the old container and restarting again. Works fine now. Changed nothing for DNS. |
If you're in swarm mode, make sure you either have sticky sessions or only one replica. |
I've fixed a few small issues that might help with this. One last thing I'll do is detach the site icon visibility from loading the greeting/weather. That way if the localisation information can't be fetched from the weather API you'll still be able to access sites. |
A note for future people who see this thread. You must remove the OWMAPIKEY and LATLONG that are mentioned in the Readme examples, they are there for example purposes only and will not actually work. |
@rdos14 This will now be fixed by commit 8810450 and commit 604171c will also ensure the OWMAPIKEY is trimmed. |
A number of small fixes have been applied in the latest release (v1.3.2) so let's see how this goes, closing the issue for now. Thanks everyone :) |
Can confirm - the fixes work! I've updated to 1.3.2 and broke DNS resolution(again!) mistakenly - icons appeared on every tab on Jump after a slight delay:) Thank you very much! |
Amazing! Thank you so much for taking the time to let me know :) |
Hi!
While using Jump for the last several months I've noticed a random bug when the icons of the websites become invisible. They are present, because when I hoover the mouse over - I can see the tooltip, and clicking them also works. When this happened last time I've noticed some errors in the logs so I thought it would be at least a starting point:)
Screenshots
First, screenshots made with Safari and Firefox(notice the tooltip and the address in the lower left corner):
Details
I was able to reproduce it on 1.3.0 and 1.2.4. Can test on any older version if needed.
Unfortunately, I haven't found the exact steps to make it happen. However, when it happened I tried doing this:
CACHE_BYPASS
variablefavicon
andsearch
featuresnone of these actions helped.
Docker command
Here is the command that I used
Steps to reproduce
Errors that I saw
So naturally, I logged into the container and did this
Looks like a path has been changed but not updated somewhere in the code?
I can also provide a full log where I saw the errors if this is of any interest:) Let me know if I can help with it any further:)
The text was updated successfully, but these errors were encountered: