fix(Select): #413 #414
Merged
fix(Select): #413 #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for react-daisyui processing.
|
✅ Deploy Preview for react-daisyui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
👷 Deploy Preview for react-daisyui processing.
|
| @@ -11,7 +16,7 @@ export type SelectProps = Omit< | |||
| 'size' | 'color' | |||
| > & | |||
| IComponentBaseProps & { | |||
| children: ReactElement<SelectOptionProps>[] | |||
| children: ListOrItem<ReactElement<SelectOptionProps>> | |||
src/types.ts
Outdated
|
|
||
| export interface IComponentBaseProps { | ||
| dataTheme?: DataTheme | ||
| } | ||
|
|
||
| export type ComponentColor = typeof componentColors[number] | ||
| export type ComponentColor = (typeof componentColors)[number] |
There was a problem hiding this comment.
Are these extra () needed?
There was a problem hiding this comment.
4f01cbe Fixed in this commit.
benjitrosch
approved these changes
Sep 15, 2023
This was referenced Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed #413