Klaas058/storybook fixes #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for react-daisyui processing.
|
✅ Deploy Preview for react-daisyui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
👷 Deploy Preview for react-daisyui processing.
|
Klaas058
commented
Oct 11, 2022
| @@ -55,15 +55,15 @@ const StoryLayout = ({ children, title, description, source }) => { | |||
| className='z-10 -mb-px' | |||
| variant='lifted' | |||
| value={tab} | |||
| onChange={(t) => setTab(t)} | |||
| onChange={(tab) => setTab(tab === 'fullWidthClick' ? 'html' : tab)} | |||
There was a problem hiding this comment.
This may seem weird but this is to preserve the current behaviour while having a different value, therefore a different key in the tab. So React doesn't complain at every component preview.
benjitrosch
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bunch of very small fixes in our storybook and a small addition to the readme