Fix children mapping keys in Carousel, CodeMockup, and Range #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for react-daisyui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
👷 Deploy Preview for react-daisyui processing.
|
benjitrosch
approved these changes
Oct 12, 2022
This was referenced Oct 31, 2022
This was referenced Dec 30, 2022
This was referenced Apr 4, 2023
This was referenced Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Components: Carousel, CodeMockup, and Range
While I was going through the storybook for (#230) I noticed there were console warning for the Carousel, CodeMockup, and Range about not giving keys while mapping children/arrays.
This is a simple PR to rectify that so our users don't get console warnings and prevent unnecessary rerenders