fix: job request errors are handled

Fixes #147

src/main/data/apis/pipeline.ts

@@ -22,6 +22,7 @@ import {
 import fetch, { Response, RequestInit } from 'node-fetch'
 
 import { info, error } from 'electron-log'
+import { jobResponseXmlToJson } from 'shared/parser/pipelineXmlConverter/jobResponseToJson'
 
 /**
  * Create a fetch function on the pipeline webservice
@@ -90,7 +91,7 @@ export const pipelineAPI = {
     launchJob: (j: Job) =>
         createPipelineFetchFunction(
             (ws) => `${baseurl(ws)}/jobs`,
-            (text) => jobXmlToJson(text),
+            (text) => jobResponseXmlToJson(text),
             {
                 method: 'POST',
                 body: jobRequestToXml({

src/renderer/components/JobDetailsPane/index.tsx

@@ -14,7 +14,19 @@ import { readableStatus } from 'shared/jobName'
 const { App } = window
 
 export function JobDetailsPane({ job }) {
-    return (
+    return job.jobData.type == 'JobRequestError' ? (
+        <>
+            <h1>Error</h1>
+            <p>{job.jobData.description}</p>
+            <button
+                onClick={(e) => {
+                    App.store.dispatch(removeJob(job))
+                }}
+            >
+                Close job
+            </button>
+        </>
+    ) : (
         <>
             <section
                 className="header"

src/shared/parser/pipelineXmlConverter/errorToJson.ts

@@ -0,0 +1,16 @@
+import { JobRequestError } from 'shared/types'
+import { parseXml } from './parser'
+
+function errorXmlToJson(xmlString: string): JobRequestError {
+    let errorElm = parseXml(xmlString, 'error')
+    let descElms = errorElm.getElementsByTagName('description')
+    let traceElms = errorElm.getElementsByTagName('trace')
+
+    return {
+        type: 'JobRequestError',
+        description: descElms.length > 0 ? descElms[0].textContent?.trim() : '',
+        trace: traceElms.length > 0 ? traceElms[0].textContent?.trim() : '',
+    }
+}
+
+export { errorXmlToJson }

src/shared/parser/pipelineXmlConverter/jobResponseToJson.ts

@@ -0,0 +1,21 @@
+// a job response could be <job...> or <error... >
+// find out which one
+
+import { errorXmlToJson } from './errorToJson'
+import { jobXmlToJson } from './jobToJson'
+import { sniffRoot } from './parser'
+
+function jobResponseXmlToJson(xmlString: string) {
+    let rootElm = sniffRoot(xmlString)
+    if (rootElm == 'error') {
+        return errorXmlToJson(xmlString)
+    }
+    else if (rootElm == 'job') {
+        return jobXmlToJson(xmlString)
+    }
+    else {
+        return {error: true, description: "Unrecognized response"}
+    }
+}
+
+export { jobResponseXmlToJson }

src/shared/parser/pipelineXmlConverter/voiceToJson.ts

@@ -1,4 +1,4 @@
-import { Voice } from 'shared/types/pipeline'
+import { Voice } from 'shared/types'
 
 function voiceElementToJson(voiceElm: Element): Voice {
     let voice: Voice = {

src/shared/types/pipeline.ts

@@ -1,4 +1,4 @@
-import { Voice } from "./ttsConfig"
+import { Voice } from './ttsConfig'
 
 /**
  * Webservice connexion data to compute url for fetch:
@@ -231,6 +231,7 @@ export type Job = {
 }
 // JobData is the JSON representation of Pipeline WS data for a single job
 export type JobData = {
+    type: 'JobRequestSuccess'
     jobId: string // the ID from the pipeline
     priority?: Priority
     status?: JobStatus
@@ -250,6 +251,13 @@ export type JobData = {
     href: string
 }
 
+// thrown by the pipeline when a job request could not be processed
+export type JobRequestError = {
+    type: 'JobRequestError'
+    description?: string
+    trace?: string
+}
+
 export enum JobState {
     NEW,
     SUBMITTED,