Release descriptors: added 1.14.2, 1.14.3, 1.14.4 and updated current to 1.14.4 #200
Conversation
|
This replaces #192, #195 and #198, right? I think there is a reason why I did not merge these. I forgot what it was exactly, but it probably has to do with that configuration files and executables have changed after 1.14.0 and the updater does not support it. And probably also with the fact that the updater has too many issues so that I prefer to not make new versions available through the updater than that people run into issues that I then have to deal with 😞 |
|
Oh, right, I didn't notice those existing PRs. We're planning a new release of the nordic migrator, and the method we will recommend to install it (as we have done for previous versions) will be using the updater. We'll also have a Docker image, which many will use, but many will also prefer a native Windows (or possibly Linux) installation. Is the nordic migrator the only real use case for the updater? When updating from for instance 1.14.3 to 1.14.4, does the .deb, .msi and .dmg files upgrade properly without the updater? Another way to install the nordic migrator could be to just drop the JAR file into the Pipeline 2 installation directory where all the other JARs are. That's what we do in the Dockerfile: COPY --from=builder /usr/src/nordic-epub3-dtbook-migrator/target/nordic-epub3-dtbook-migrator-*.jar /opt/daisy-pipeline2/system/common/I suppose that might cause problems in some instances if the user that installs it doesn't have permissions to write to that directory (typically in Windows), but maybe that's a limitation we can live with. Do you think that would be a better solution? Then you could deprecate the updater to lower the maintenance cost of Pipeline 2? |
Do you need the 1.14.2, 1.14.3 and 1.14.4 release descriptors for that though? Isn't all you need your custom release descriptor for the Nordic migrator? Wouldn't you recommend installing version 1.14.4 of Pipeline and then running the updater?
I don't quite understand the question.
Sure, that's always an option too.
I don't know. I've used it some times in the past to make new versions available. But because the non-JAR files (configuration files and executables) have been changing a lot, it couldn't be used often, and if it can't be used consistently I think it's better to not use it at all. |
That's true, none of these descriptors are needed, I just noticed that they were missing and created a PR for them. If they're not needed, feel free to close this PR.
I mean, is the updater used internally when upgrading from one version to another? If you install one version of Pipeline 2 on Windows using the MSI installer; and then a new version of Pipeline 2 comes out with a new MSI installer. Do you need to uninstall the previous version of Pipeline 2 first, or will the new version replace the old version automatically? |
|
Yes AFAIK the uninstallation happens automatically. |
|
Ok. So not much use for the updater then. So from now on the decriptor is only really needed for the version attribute in /alive I guess. |
|
The updater has potential for sure. But I think some issues need to be addressed before I'm going to use it more "officially". But for cases like installing the Nordic migrator it can already be useful. |
|
Can be closed as wontfix I think? |
|
Yes. |
No description provided.