Skip to content

Commit

Permalink
fix(CI): GitHub Actions Electron disable GPU via forwarded command li…
Browse files Browse the repository at this point in the history
…ne arguments (as opposed to forcing in code)
  • Loading branch information
danielweck committed Feb 5, 2025
1 parent f6981b8 commit de41fa5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
- run: git --no-pager diff
# - run: yarn install --frozen-lockfile
# - name: YARN install
# # yarn cache clean && yarn config delete proxy && yarn config delete https-proxy && yarn config delete registry &&
# # yarn cache clean && yarn config delete proxy && yarn config delete https-proxy && yarn config delete registry &&
# run: 'yarn install --network-timeout 1000000'
# shell: bash
# - name: PR action
Expand Down Expand Up @@ -102,10 +102,10 @@ jobs:
# run: yarn test-electron && yarn test-electron-cli
# working-directory: ./
# # options:
run: echo "${{ matrix.osarch }}" && xvfb-run --auto-servernum yarn test-electron-cli && xvfb-run --auto-servernum yarn test-electron
run: echo "${{ matrix.osarch }}" && xvfb-run --auto-servernum yarn test-electron && xvfb-run --auto-servernum yarn test-electron-cli --disable-gpu
- name: non-PR action, Mac, Puppeteer
if: ${{ github.event_name != 'pull_request' && (matrix.osarch == 'macos-intel' || matrix.osarch == 'macos-arm') }}
run: echo "${{ matrix.osarch }}" && yarn test && yarn test-cli
- name: non-PR action, Mac, Electron
if: ${{ github.event_name != 'pull_request' && (matrix.osarch == 'macos-intel' || matrix.osarch == 'macos-arm') }}
run: echo "${{ matrix.osarch }}" && yarn test-electron && yarn test-electron-cli
run: echo "${{ matrix.osarch }}" && yarn test-electron && yarn test-electron-cli --disable-gpu
2 changes: 1 addition & 1 deletion packages/ace-axe-runner-electron/src/cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const protocol = electron.protocol;
// --in-process-gpu ?
// app.commandLine.appendSwitch("in-process-gpu");
// ------------------------------------ see patchElectronJestRunner4
app.commandLine.appendSwitch("disable-gpu");
// app.commandLine.appendSwitch("disable-gpu");
// app.disableHardwareAcceleration();
// app.commandLine.appendSwitch("disable-software-rasterizer");

Expand Down

0 comments on commit de41fa5

Please sign in to comment.