Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A11Y sort functionality #28

Closed
SarahMagdalena opened this issue Oct 18, 2018 · 1 comment
Closed

A11Y sort functionality #28

SarahMagdalena opened this issue Oct 18, 2018 · 1 comment
Assignees
@marisademeglio
Labels
bug Something isn't working

Comments

@SarahMagdalena
Copy link
Collaborator

It seems to me like the A11Y sort functionality in the metadata view doesn't work properly...
I tried an ePub which has both dc metadata and accessibility metadata. The third column of the metadata table shows "Yes" for the accessibility metadata and is empty for the other ones.
When pressing A11Y sort, I would expect the entries to be sorted according to this entry, but the order actually doesn't change.
@rdeltour
Copy link
Member

I'll look into it, thanks for the report!

@marisademeglio marisademeglio self-assigned this Dec 7, 2018
marisademeglio added a commit that referenced this issue Dec 8, 2018
@marisademeglio
fix: a11y column sorting
1a6e01c 
Fixes #28
The field a11y is now part of the underlying data (set in MetadataContainer.js) so it can be sorted.
marisademeglio added a commit that referenced this issue Dec 8, 2018
@marisademeglio
fix: a11y column sorting
8af4309 
Fixes #28
The field a11y is now part of the underlying data (set in MetadataContainer.js) so it can be sorted.
@marisademeglio marisademeglio mentioned this issue Dec 8, 2018
Closed
@marisademeglio marisademeglio reopened this Dec 8, 2018
@rdeltour rdeltour added the bug Something isn't working label Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marisademeglio marisademeglio

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rdeltour @marisademeglio @SarahMagdalena