Merge pull request #72 from daisugiland/replace-rome

refactor: replace rome with biome

.vscode/extensions.json

@@ -5,6 +5,7 @@
     "vivaxy.vscode-conventional-commits",
     "yoavbls.pretty-ts-errors",
     "richie5um2.vscode-sort-json",
-    "rome.rome"
+    "biomejs.biome",
+    "usernamehw.errorlens"
   ]
 }

.vscode/settings.json

@@ -1,9 +1,9 @@
 {
   "[javascript]": {
-    "editor.defaultFormatter": "rome.rome"
+    "editor.defaultFormatter": "biomejs.biome"
   },
   "[typescript]": {
-    "editor.defaultFormatter": "rome.rome"
+    "editor.defaultFormatter": "biomejs.biome"
   },
   "cSpell.words": [
     "anzen",
@@ -33,8 +33,8 @@
     "**/node_modules/": true
   },
   "editor.codeActionsOnSave": {
-    "quickfix.rome": true,
-    "source.organizeImports.rome": true,
+    "quickfix.biome": true,
+    "source.organizeImports.biome": true,
     "source.addMissingImports": true,
     "source.fixAll.sortJSON": true
   },

biome.json

@@ -0,0 +1,27 @@
+{
+	"$schema": "https://biomejs.dev/schemas/1.2.2/schema.json",
+	"formatter": {
+		"indentSize": 2,
+		"indentStyle": "space",
+		"lineWidth": 60
+	},
+	"javascript": {
+		"formatter": {
+			"quoteProperties": "asNeeded",
+			"quoteStyle": "single",
+			"semicolons": "always",
+			"trailingComma": "all"
+		}
+	},
+	"linter": {
+		"enabled": true,
+		"rules": {
+			"suspicious": {
+				"noExplicitAny": "off"
+			}
+		}
+	},
+	"organizeImports": {
+		"enabled": true
+	}
+}

package.json

@@ -28,10 +28,10 @@
     "node": ">= 18.15.0"
   },
   "devDependencies": {
-    "@lerna-lite/cli": "^2.5.0",
-    "@lerna-lite/publish": "^2.5.0",
-    "@lerna-lite/run": "^2.5.0",
-    "rome": "^12.1.3",
+    "@biomejs/biome": "^1.2.2",
+    "@lerna-lite/cli": "^2.5.1",
+    "@lerna-lite/publish": "^2.5.1",
+    "@lerna-lite/run": "^2.5.1",
     "tslib": "^2.6.2",
     "typescript": "^5.2.2"
   }

packages/anzen/package.json

@@ -14,8 +14,8 @@
   },
   "scripts": {
     "build": "rm -rf dist && tsc --build ./tsconfig_esm.json && tsc --project ./tsconfig_cjs.json",
-    "check": "rome check src --apply-unsafe",
-    "format": "rome format src --write",
+    "check": "biome check src --apply-unsafe",
+    "format": "biome format src --write",
     "prepublishOnly": "pnpm run test && pnpm run build",
     "tdd": "tsc-watch --build ./tsconfig.json --onSuccess \"node --test --test-reporter spec dist/esm/__tests__/*.js\"",
     "test": "tsc --build ./tsconfig.json && node --test --test-reporter spec dist/esm/__tests__/*.js"
@@ -49,8 +49,8 @@
   },
   "types": "dist/types/anzen.d.ts",
   "devDependencies": {
-    "@types/node": "^18.17.14",
-    "rome": "^12.1.3",
+    "@biomejs/biome": "^1.2.2",
+    "@types/node": "^18.17.17",
     "tsc-watch": "^6.0.4",
     "typescript": "^5.2.2"
   }

packages/anzen/src/anzen.ts

@@ -118,6 +118,7 @@ async function handleResult(
   return response.getValue();
 }
 
+// biome-ignore lint/complexity/noStaticOnlyClass: <explanation>
 export class Result {
   static success<T>(value: T) {
     return new ResultSuccess<T>(value);

packages/ayamari/package.json

@@ -14,8 +14,8 @@
   },
   "scripts": {
     "build": "rm -rf dist && tsc --build ./tsconfig_esm.json && tsc --project ./tsconfig_cjs.json",
-    "check": "rome check src --apply-unsafe",
-    "format": "rome format src --write",
+    "check": "biome check src --apply-unsafe",
+    "format": "biome format src --write",
     "prepublishOnly": "pnpm run test && pnpm run build",
     "tdd": "tsc-watch --build ./tsconfig.json --onSuccess \"node --test --test-reporter spec dist/esm/__tests__/*.js\"",
     "test": "tsc --build ./tsconfig.json && node --test --test-reporter spec dist/esm/__tests__/*.js"
@@ -57,8 +57,8 @@
     "@daisugi/anzen": "workspace:*"
   },
   "devDependencies": {
-    "@types/node": "^18.17.14",
-    "rome": "^12.1.3",
+    "@biomejs/biome": "^1.2.2",
+    "@types/node": "^18.17.17",
     "tsc-watch": "^6.0.4",
     "typescript": "^5.2.2"
   }

packages/ayamari/src/pretty_stack.ts

@@ -1,5 +1,6 @@
 import type { AyamariErr } from './ayamari.js';
 
+// biome-ignore lint/complexity/noStaticOnlyClass: <explanation>
 export class PrettyStack {
   /** Kindly borrowed from https://github.com/errwischt/stacktrace-parser/blob/master/src/stack-trace-parser.js */
   static #lineRe =

packages/daisugi/package.json

@@ -14,8 +14,8 @@
   },
   "scripts": {
     "build": "rm -rf dist && tsc --build ./tsconfig_esm.json && tsc --project ./tsconfig_cjs.json",
-    "check": "rome check src --apply-unsafe",
-    "format": "rome format src --write",
+    "check": "biome check src --apply-unsafe",
+    "format": "biome format src --write",
     "prepublishOnly": "pnpm run test && pnpm run build",
     "tdd": "tsc-watch --build ./tsconfig.json --onSuccess \"node --test --test-reporter spec dist/esm/__tests__/*.js\"",
     "test": "tsc --build ./tsconfig.json && node --test --test-reporter spec dist/esm/__tests__/*.js"
@@ -52,8 +52,8 @@
     "@daisugi/ayamari": "workspace:*"
   },
   "devDependencies": {
-    "@types/node": "^18.17.14",
-    "rome": "^12.1.3",
+    "@biomejs/biome": "^1.2.2",
+    "@types/node": "^18.17.17",
     "tsc-watch": "^6.0.4",
     "typescript": "^5.2.2"
   }

packages/kado/package.json

@@ -14,8 +14,8 @@
   },
   "scripts": {
     "build": "rm -rf dist && tsc --build ./tsconfig_esm.json && tsc --project ./tsconfig_cjs.json",
-    "check": "rome check src --apply-unsafe",
-    "format": "rome format src --write",
+    "check": "biome check src --apply-unsafe",
+    "format": "biome format src --write",
     "prepublishOnly": "pnpm run test && pnpm run build",
     "tdd": "tsc-watch --build ./tsconfig.json --onSuccess \"node --test --test-reporter spec dist/esm/__tests__/*.js\"",
     "test": "tsc --build ./tsconfig.json && node --test --test-reporter spec dist/esm/__tests__/*.js"
@@ -55,8 +55,8 @@
     "@daisugi/kintsugi": "workspace:*"
   },
   "devDependencies": {
-    "@types/node": "^18.17.14",
-    "rome": "^12.1.3",
+    "@biomejs/biome": "^1.2.2",
+    "@types/node": "^18.17.17",
     "tsc-watch": "^6.0.4",
     "typescript": "^5.2.2"
   }

packages/kado/src/__tests__/kado_test.ts

@@ -1,8 +1,12 @@
-import { Ayamari, type AyamariErr } from '@daisugi/ayamari';
 import assert from 'node:assert/strict';
 import { describe, it } from 'node:test';
+import { Ayamari, type AyamariErr } from '@daisugi/ayamari';
 
-import { Kado, type KadoContainer, type KadoManifestItem } from '../kado.js';
+import {
+  Kado,
+  type KadoContainer,
+  type KadoManifestItem,
+} from '../kado.js';
 
 describe('Kado', () => {
   it('should have proper api', () => {
@@ -13,8 +17,14 @@ describe('Kado', () => {
 
     const { container } = new Kado();
 
-    assert.strictEqual(typeof container.resolve, 'function');
-    assert.strictEqual(typeof container.register, 'function');
+    assert.strictEqual(
+      typeof container.resolve,
+      'function',
+    );
+    assert.strictEqual(
+      typeof container.register,
+      'function',
+    );
     assert.strictEqual(typeof container.list, 'function');
     assert.strictEqual(typeof container.get, 'function');
   });
@@ -90,11 +100,11 @@ describe('Kado', () => {
   it('useClass Transient', async () => {
     const { container } = new Kado();
 
-    class A {
-      constructor() {}
-    }
+    class A {}
 
-    container.register([{ token: 'A', useClass: A, scope: 'Transient' }]);
+    container.register([
+      { token: 'A', useClass: A, scope: 'Transient' },
+    ]);
 
     const a = await container.resolve<A>('A');
     const anotherA = await container.resolve<A>('A');
@@ -177,7 +187,9 @@ describe('Kado', () => {
 
       container.register(manifestItems);
 
-      const a = await container.resolve<KadoManifestItem[]>('A');
+      const a = await container.resolve<KadoManifestItem[]>(
+        'A',
+      );
 
       assert.deepEqual(a, manifestItems);
     });
@@ -291,7 +303,9 @@ describe('Kado', () => {
 
     const list = container.list();
 
-    assert.deepStrictEqual(list, [{ token: 'a', useValue: 'text' }]);
+    assert.deepStrictEqual(list, [
+      { token: 'a', useValue: 'text' },
+    ]);
   });
 
   it('#list() with symbol keys', () => {
@@ -301,7 +315,9 @@ describe('Kado', () => {
 
     const list = container.list();
 
-    assert.deepStrictEqual(list, [{ token, useValue: 'text' }]);
+    assert.deepStrictEqual(list, [
+      { token, useValue: 'text' },
+    ]);
   });
 
   describe('when you try to resolve unregistered token', () => {
@@ -315,8 +331,14 @@ describe('Kado', () => {
           (err as AyamariErr).message,
           'Attempted to resolve unregistered dependency token: "a".',
         );
-        assert.strictEqual((err as AyamariErr).code, Ayamari.errCode.NotFound);
-        assert.strictEqual((err as AyamariErr).name, 'NotFound [404]');
+        assert.strictEqual(
+          (err as AyamariErr).code,
+          Ayamari.errCode.NotFound,
+        );
+        assert.strictEqual(
+          (err as AyamariErr).name,
+          'NotFound [404]',
+        );
       }
     });
   });
@@ -325,7 +347,9 @@ describe('Kado', () => {
     it('should throw an err', async () => {
       const { container } = new Kado();
 
-      container.register([{ token: 'a', useFn() {}, params: ['b'] }]);
+      container.register([
+        { token: 'a', useFn() {}, params: ['b'] },
+      ]);
 
       try {
         await container.resolve('a');
@@ -334,8 +358,14 @@ describe('Kado', () => {
           (err as AyamariErr).message,
           'Attempted to resolve unregistered dependency token: "b".',
         );
-        assert.strictEqual((err as AyamariErr).code, Ayamari.errCode.NotFound);
-        assert.strictEqual((err as AyamariErr).name, 'NotFound [404]');
+        assert.strictEqual(
+          (err as AyamariErr).code,
+          Ayamari.errCode.NotFound,
+        );
+        assert.strictEqual(
+          (err as AyamariErr).name,
+          'NotFound [404]',
+        );
       }
     });
   });
@@ -389,12 +419,14 @@ describe('Kado', () => {
         constructor(public b: B) {}
       }
 
-      class B {
-        constructor() {}
-      }
+      class B {}
 
       class A {
-        constructor(public b: B, public b2: B, public c: C) {}
+        constructor(
+          public b: B,
+          public b2: B,
+          public c: C,
+        ) {}
       }
 
       container.register([

packages/kintsugi/package.json

@@ -14,8 +14,8 @@
   },
   "scripts": {
     "build": "rm -rf dist && tsc --build ./tsconfig_esm.json && tsc --project ./tsconfig_cjs.json",
-    "check": "rome check src --apply-unsafe",
-    "format": "rome format src --write",
+    "check": "biome check src --apply-unsafe",
+    "format": "biome format src --write",
     "prepublishOnly": "pnpm run test && pnpm run build",
     "tdd": "tsc-watch --build ./tsconfig.json --onSuccess \"node --test --test-reporter spec dist/esm/__tests__/*.js\"",
     "test": "tsc --build ./tsconfig.json && node --test --test-reporter spec dist/esm/__tests__/*.js"
@@ -55,8 +55,8 @@
     "@daisugi/ayamari": "workspace:*"
   },
   "devDependencies": {
-    "@types/node": "^18.17.14",
-    "rome": "^12.1.3",
+    "@biomejs/biome": "^1.2.2",
+    "@types/node": "^18.17.17",
     "ts-mockito": "^2.6.1",
     "tsc-watch": "^6.0.4",
     "typescript": "^5.2.2"

packages/kintsugi/src/__tests__/with_cache_test.ts

@@ -1,6 +1,6 @@
-import { Result, type ResultSuccess } from '@daisugi/anzen';
 import assert from 'node:assert/strict';
 import { describe, it } from 'node:test';
+import { Result, type ResultSuccess } from '@daisugi/anzen';
 import { between, spy } from 'ts-mockito';
 
 import { SimpleMemoryStore } from '../simple_memory_store.js';

packages/kintsugi/src/enc_to_fnv1a.ts

@@ -21,7 +21,7 @@
 
 const OFFSET_BASIS_32 = 2166136261;
 
-function fnv1aString(string: String) {
+function fnv1aString(string: string) {
   let hash = OFFSET_BASIS_32;
   for (let i = 0; i < string.length; i++) {
     hash ^= string.charCodeAt(i);

packages/kintsugi/src/with_circuit_breaker.ts

@@ -1,10 +1,10 @@
+import { setInterval } from 'node:timers';
 import {
   type AnzenAnyResult,
   type AnzenResultFn,
   Result,
 } from '@daisugi/anzen';
 import { Ayamari } from '@daisugi/ayamari';
-import { setInterval } from 'node:timers';
 
 const { errFn, errCode } = new Ayamari();
 

packages/land/package.json

@@ -14,8 +14,8 @@
   },
   "scripts": {
     "build": "rm -rf dist && tsc --build ./tsconfig_esm.json && tsc --project ./tsconfig_cjs.json",
-    "check": "rome check src --apply-unsafe",
-    "format": "rome format src --write",
+    "check": "biome check src --apply-unsafe",
+    "format": "biome format src --write",
     "prepublishOnly": "pnpm run test && pnpm run build",
     "tdd": "tsc-watch --build ./tsconfig.json --onSuccess \"node --test --test-reporter spec dist/esm/__tests__/*.js\"",
     "test": "tsc --build ./tsconfig.json && node --test --test-reporter spec dist/esm/__tests__/*.js"
@@ -63,8 +63,8 @@
     "@daisugi/nekobasu": "workspace:*"
   },
   "devDependencies": {
-    "@types/node": "^18.17.14",
-    "rome": "^12.1.3",
+    "@biomejs/biome": "^1.2.2",
+    "@types/node": "^18.17.17",
     "tsc-watch": "^6.0.4",
     "typescript": "^5.2.2"
   }