fix: paddle transaction management for gifting #2648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshanzel
requested review from
rebelchris,
omBratteng,
ilasw,
nensidosari and
AmarTrebinjac
sshanzel
commented
Feb 8, 2025
Comment on lines
-89
to
-115
| const { gifter_id: gifterId } = customData; | ||
| const duration = subscriptionGiftDuration; | ||
| const isGift = !!gifterId; | ||
| if (isGift) { | ||
| if (userId === gifterId) { | ||
| logger.error({ type: 'paddle', data }, 'User and gifter are the same'); | ||
| return false; | ||
| } | ||
|
|
||
| const gifterUser = await con | ||
| .getRepository(User) | ||
| .findOneBy({ id: gifterId }); | ||
| if (!gifterUser) { | ||
| logger.error({ type: 'paddle', data }, 'Gifter user not found'); | ||
| return false; | ||
| } | ||
|
|
||
| const targetUser = await con.getRepository(User).findOne({ | ||
| select: ['subscriptionFlags'], | ||
| where: { id: userId }, | ||
| }); | ||
| if (isPlusMember(targetUser?.subscriptionFlags?.cycle)) { | ||
| logger.error({ type: 'paddle', data }, 'User is already a Plus member'); | ||
| return false; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Moved to its own function to lessen the noise here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-time payments are not considered subscriptions in Paddle's dictionary, so we must handle the event for gifting within the TransactionCompleted. Events available are as below:
Test cases still check out.