Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: translate smart title during fetch #2643

Merged
merged 15 commits into from
Feb 6, 2025

Conversation

capJavert
Copy link
Contributor

@capJavert capJavert commented Feb 6, 2025

  • also fallbacks title graphorm field when smart title is returned since it used same utils

@capJavert capJavert self-assigned this Feb 6, 2025
@capJavert capJavert requested a review from a team as a code owner February 6, 2025 01:20
@capJavert capJavert requested review from rebelchris, omBratteng, ilasw, sshanzel, nensidosari and AmarTrebinjac and removed request for a team February 6, 2025 01:20
Copy link
Contributor

@rebelchris rebelchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part looks ok to me.

Comment on lines +6320 to +6324
const res = await client.query(QUERY, {
headers: {
'content-language': 'de',
},
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love that we can do this via headers actually :)

Base automatically changed from AS-963-update-postupdate-worker to main February 6, 2025 14:32
@capJavert capJavert merged commit ad41118 into main Feb 6, 2025
8 checks passed
@capJavert capJavert deleted the AS-964-fetch-smart-title-translation branch February 6, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants