Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: store alt_title in translation #2636

Merged
merged 11 commits into from
Feb 6, 2025
Merged

Conversation

omBratteng
Copy link
Member

@omBratteng omBratteng commented Jan 31, 2025

I first tried to use SQL functions, but then encountered escape issue with ', so went with js object route

jsonb_set(
    translation,
    '{en}',
    COALESCE(translation->'en', '{}'::jsonb) || jsonb_build_object('smartTitle', '${smartTitle}'),
    true
  )

AS-963

@omBratteng omBratteng requested review from capJavert and a team as code owners January 31, 2025 14:02
@omBratteng omBratteng requested review from rebelchris, ilasw, sshanzel, nensidosari and AmarTrebinjac and removed request for a team January 31, 2025 14:02

This comment has been minimized.

@omBratteng omBratteng changed the title fix: remove unnecessary await fix: store alt_title in translation Jan 31, 2025

This comment has been minimized.

src/workers/postUpdated.ts Outdated Show resolved Hide resolved
Base automatically changed from AS-967-translatable-field to main January 31, 2025 16:38

This comment has been minimized.

@omBratteng omBratteng requested a review from capJavert January 31, 2025 17:40

This comment has been minimized.

This comment has been minimized.

@rebelchris
Copy link
Contributor

@capJavert You ok with this one, or you want any changes?

@capJavert
Copy link
Contributor

@rebelchris yes, just gonna test it a bit more and then merge

This comment has been minimized.

@capJavert capJavert enabled auto-merge (squash) February 6, 2025 13:43
Copy link

pulumi bot commented Feb 6, 2025

🍹 The Update (preview) for dailydotdev/api/prod was successful.

Resource Changes

    Name                                            Type                           Operation
~   vpc-native-personalized-digest-cron             kubernetes:batch/v1:CronJob    update
~   vpc-native-daily-digest-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-bg-deployment                        kubernetes:apps/v1:Deployment  update
~   vpc-native-update-views-cron                    kubernetes:batch/v1:CronJob    update
~   vpc-native-update-source-public-threshold-cron  kubernetes:batch/v1:CronJob    update
~   vpc-native-sync-subscription-with-cio-cron      kubernetes:batch/v1:CronJob    update
~   vpc-native-generate-search-invites-cron         kubernetes:batch/v1:CronJob    update
~   vpc-native-ws-deployment                        kubernetes:apps/v1:Deployment  update
~   vpc-native-personalized-digest-deployment       kubernetes:apps/v1:Deployment  update
~   vpc-native-update-source-tag-view-cron          kubernetes:batch/v1:CronJob    update
~   vpc-native-validate-active-users-cron           kubernetes:batch/v1:CronJob    update
~   vpc-native-check-analytics-report-cron          kubernetes:batch/v1:CronJob    update
+   vpc-native-api-migration-8fe34dbf               kubernetes:batch/v1:Job        create
~   vpc-native-generic-referral-reminder-cron       kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-users-cron              kubernetes:batch/v1:CronJob    update
~   vpc-native-hourly-notification-cron             kubernetes:batch/v1:CronJob    update
-   vpc-native-api-migration-0a00d1cc               kubernetes:batch/v1:Job        delete
~   vpc-native-calculate-top-readers-cron           kubernetes:batch/v1:CronJob    update
~   vpc-native-update-trending-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-update-tag-recommendations-cron      kubernetes:batch/v1:CronJob    update
~   vpc-native-update-highlighted-views-cron        kubernetes:batch/v1:CronJob    update
~   vpc-native-private-deployment                   kubernetes:apps/v1:Deployment  update
~   vpc-native-clean-gifted-plus-cron               kubernetes:batch/v1:CronJob    update
~   vpc-native-deployment                           kubernetes:apps/v1:Deployment  update
~   vpc-native-temporal-deployment                  kubernetes:apps/v1:Deployment  update
~   vpc-native-update-tags-str-cron                 kubernetes:batch/v1:CronJob    update
~   vpc-native-update-current-streak-cron           kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-user-companies-cron     kubernetes:batch/v1:CronJob    update
~   vpc-native-clean-zombie-images-cron             kubernetes:batch/v1:CronJob    update

@capJavert capJavert disabled auto-merge February 6, 2025 14:32
@capJavert capJavert merged commit e980514 into main Feb 6, 2025
7 of 8 checks passed
@capJavert capJavert deleted the AS-963-update-postupdate-worker branch February 6, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants