refactor: read valid languages from remote config #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omBratteng
requested review from
rebelchris,
ilasw,
sshanzel,
nensidosari and
AmarTrebinjac
omBratteng
commented
Jan 30, 2025
src/remoteConfig.ts
Outdated
Comment on lines
48
to
56
| return { | ||
| validLanguages: { | ||
| de: 'German', | ||
| en: 'English', | ||
| es: 'Spanish', | ||
| no: 'Norwegian', | ||
| fr: 'French', | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Just a starting point so that we have some valid languages locally
This comment has been minimized.
This comment has been minimized.
omBratteng
commented
Jan 30, 2025
| @@ -206,8 +206,6 @@ export enum ContentLanguage { | |||
|
|
|||
| export type I18nRecord = Partial<Record<ContentLanguage, string>>; | |||
There was a problem hiding this comment.
Leaving the ContentLanguage enum for now, it's not really used anymore other than a type.
This comment has been minimized.
This comment has been minimized.
capJavert
approved these changes
Jan 30, 2025
rebelchris
approved these changes
Jan 30, 2025
This comment has been minimized.
This comment has been minimized.
rebelchris
approved these changes
Jan 30, 2025
__tests__/setup.ts
Outdated
| } as typeof remoteConfig.vars, | ||
| }, | ||
| validLanguages: { |
There was a problem hiding this comment.
Shouldn't this me snake_case?
There was a problem hiding this comment.
Oh you map it internally I see :)
capJavert
approved these changes
Jan 30, 2025
Co-authored-by: Ante Barić <ante@kickass.website>
This comment has been minimized.
This comment has been minimized.
|
🍹 The Update (preview) for dailydotdev/api/prod was successful. Resource Changes Name Type Operation
~ vpc-native-temporal-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-update-tags-str-cron kubernetes:batch/v1:CronJob update
+- vpc-native-k8s-secret kubernetes:core/v1:Secret create-replacement
~ vpc-native-hourly-notification-cron kubernetes:batch/v1:CronJob update
~ vpc-native-generic-referral-reminder-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-user-companies-cron kubernetes:batch/v1:CronJob update
~ vpc-native-private-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-clean-gifted-plus-cron kubernetes:batch/v1:CronJob update
~ vpc-native-personalized-digest-cron kubernetes:batch/v1:CronJob update
~ vpc-native-clean-zombie-users-cron kubernetes:batch/v1:CronJob update
~ vpc-native-sync-subscription-with-cio-cron kubernetes:batch/v1:CronJob update
~ vpc-native-generate-search-invites-cron kubernetes:batch/v1:CronJob update
- vpc-native-api-migration-b9cb1768 kubernetes:batch/v1:Job delete
~ vpc-native-update-source-tag-view-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-current-streak-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-tag-recommendations-cron kubernetes:batch/v1:CronJob update
- vpc-native-api-migration-9d896d90 kubernetes:batch/v1:Job delete
~ vpc-native-ws-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-bg-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-daily-digest-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-trending-cron kubernetes:batch/v1:CronJob update
~ vpc-native-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-clean-zombie-images-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-source-public-threshold-cron kubernetes:batch/v1:CronJob update
+ vpc-native-api-migration-b85ff3e5 kubernetes:batch/v1:Job create
~ vpc-native-calculate-top-readers-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-views-cron kubernetes:batch/v1:CronJob update
~ vpc-native-update-highlighted-views-cron kubernetes:batch/v1:CronJob update
~ vpc-native-personalized-digest-deployment kubernetes:apps/v1:Deployment update
~ vpc-native-validate-active-users-cron kubernetes:batch/v1:CronJob update
~ vpc-native-check-analytics-report-cron kubernetes:batch/v1:CronJob update
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches Kvasir so they validate the same languages.