Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add grouped argument so we can extract grouped dates #2601

Merged
merged 4 commits into from
Jan 16, 2025
Merged

feat: add grouped argument so we can extract grouped dates #2601

merged 4 commits into from
Jan 16, 2025

Conversation

capJavert
Copy link
Contributor

@capJavert capJavert commented Jan 16, 2025 •
edited
Loading

fixes calendar heatmap thread

  • for reading streaks we needed exact times with time portion of date so that we can accurately know when did user read occur, which conflicted with a way we return read history currently
  • this adds a grouped param which for now allows us to retain that functionality for calendar heatmap
  • heatmap will again return dates in user's timezone to preserve heatmap logic, we can look into adjusting that in the future but for now its ok

Frontend PR dailydotdev/apps#4073

@capJavert capJavert self-assigned this Jan 16, 2025
@capJavert capJavert mentioned this pull request Jan 16, 2025
Merged
@capJavert capJavert marked this pull request as ready for review January 16, 2025 17:06
@capJavert capJavert requested a review from a team as a code owner January 16, 2025 17:06
@capJavert capJavert merged commit f30aabf into main Jan 16, 2025
8 checks passed
@capJavert capJavert deleted the fix-read-history branch January 16, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelchris rebelchris rebelchris approved these changes

@omBratteng omBratteng Awaiting requested review from omBratteng omBratteng is a code owner automatically assigned from dailydotdev/web-team

@ilasw ilasw Awaiting requested review from ilasw ilasw is a code owner automatically assigned from dailydotdev/web-team

@sshanzel sshanzel Awaiting requested review from sshanzel sshanzel is a code owner automatically assigned from dailydotdev/web-team

@nensidosari nensidosari Awaiting requested review from nensidosari nensidosari is a code owner automatically assigned from dailydotdev/web-team

@AmarTrebinjac AmarTrebinjac Awaiting requested review from AmarTrebinjac AmarTrebinjac is a code owner automatically assigned from dailydotdev/web-team

Assignees

@capJavert capJavert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@capJavert @rebelchris