Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add filter for blocked following/followed users #2595

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

ilasw
Copy link
Contributor

@ilasw ilasw commented Jan 14, 2025

No description provided.

@ilasw ilasw marked this pull request as ready for review January 14, 2025 14:21
@ilasw ilasw requested review from capJavert and a team as code owners January 14, 2025 14:21
Copy link
Contributor

@AmarTrebinjac AmarTrebinjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Did a user test as well, seems to work as it should

@@ -524,9 +524,11 @@ export const whereNotUserBlocked = (
{
userId,
feedId,
columnName = 'userId',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make this union userId | referenceId

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I think that I didn't understand this, can you please give an example for this? Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type it as 'userId' | 'referenceId' instead of string

@ilasw ilasw merged commit f30950f into main Jan 16, 2025
7 of 8 checks passed
@ilasw ilasw deleted the MI-727-filter-blocked-users-in-follow-list branch January 16, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants