fix: add allowed_content_curation flag to feed config #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omBratteng
approved these changes
Aug 9, 2024
capJavert
approved these changes
Aug 9, 2024
capJavert
approved these changes
Aug 9, 2024
idoshamun
reviewed
Aug 11, 2024
src/integrations/feed/configs.ts
Outdated
| filters.blockedContentCuration?.length && | ||
| opts.includeBlockedContentCuration | ||
| ) { | ||
| if (filters.blockedContentCuration?.length && opts.includeContentCuration) { | ||
| baseConfig.blocked_content_curations = filters.blockedContentCuration; |
There was a problem hiding this comment.
I think we don't need this anymore now
There was a problem hiding this comment.
What about the lofn provider? (And maybe the one that uses the digest?)
@vpol you probably know best, can we remove it?
There was a problem hiding this comment.
lofn does not use/parse any of the filters at all.
There was a problem hiding this comment.
And with your fix nothing else uses the old format right so removing it is fine? 🙏
There was a problem hiding this comment.
we still support it on the feed side, but if you are not going to use it - it's ok.
idoshamun
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
allowed_content_curationsconfig if user has any blocked items.Also noticed we didn't even have a test for blocked_content_curations so added one that covers both cases now.
AS-505 #done