Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set vordr flags on comment reply #2117

Merged
merged 2 commits into from
Aug 8, 2024
Merged

fix: set vordr flags on comment reply #2117

merged 2 commits into from
Aug 8, 2024

Conversation

omBratteng
Copy link
Member

No description provided.

@omBratteng omBratteng requested review from capJavert and a team as code owners August 8, 2024 10:27
idoshamun
idoshamun reviewed Aug 8, 2024
View reviewed changes
Copy link
Member

@idoshamun idoshamun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add tests?

@omBratteng
Copy link
Member Author

Should we add tests?

Probably... I see I forgot tests for commentOnPost mutation too

@omBratteng omBratteng requested a review from idoshamun August 8, 2024 10:37
@omBratteng omBratteng merged commit 9965be2 into main Aug 8, 2024
8 checks passed
@omBratteng omBratteng deleted the vordr-reply branch August 8, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idoshamun idoshamun idoshamun approved these changes

@capJavert capJavert Awaiting requested review from capJavert capJavert is a code owner

@rebelchris rebelchris Awaiting requested review from rebelchris rebelchris is a code owner automatically assigned from dailydotdev/web-team

@ilasw ilasw Awaiting requested review from ilasw ilasw is a code owner automatically assigned from dailydotdev/web-team

@sshanzel sshanzel Awaiting requested review from sshanzel sshanzel is a code owner automatically assigned from dailydotdev/web-team

@nensidosari nensidosari Awaiting requested review from nensidosari nensidosari is a code owner automatically assigned from dailydotdev/web-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omBratteng @idoshamun