Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow changing integration if user is the same #2115

Merged
merged 3 commits into from
Aug 8, 2024
Merged

fix: allow changing integration if user is the same #2115

merged 3 commits into from
Aug 8, 2024

Conversation

capJavert
Copy link
Contributor

  • we are currently limiting slack integration to one per squad
  • currently when existing user is changing integration it would fail because integration already exists
  • with this fix it allows the change if userId of new integration is the same as existing one

@capJavert capJavert self-assigned this Aug 8, 2024
@capJavert capJavert requested a review from a team as a code owner August 8, 2024 07:54
@capJavert capJavert enabled auto-merge (squash) August 8, 2024 11:11
@capJavert capJavert merged commit 92e6be6 into main Aug 8, 2024
8 checks passed
@capJavert capJavert deleted the fix-slack-integration-change branch August 8, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebelchris rebelchris rebelchris approved these changes

@omBratteng omBratteng Awaiting requested review from omBratteng omBratteng is a code owner automatically assigned from dailydotdev/web-team

@ilasw ilasw Awaiting requested review from ilasw ilasw is a code owner automatically assigned from dailydotdev/web-team

@sshanzel sshanzel Awaiting requested review from sshanzel sshanzel is a code owner automatically assigned from dailydotdev/web-team

@nensidosari nensidosari Awaiting requested review from nensidosari nensidosari is a code owner automatically assigned from dailydotdev/web-team

Assignees

@capJavert capJavert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@capJavert @rebelchris