Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: vordr on profile replies and discussion feed #2102

Merged
merged 5 commits into from
Aug 6, 2024
Merged

feat: vordr on profile replies and discussion feed #2102

merged 5 commits into from
Aug 6, 2024

Conversation

omBratteng
Copy link
Member

Vordr on Profile replies and Discussion feed

@omBratteng omBratteng requested a review from idoshamun August 5, 2024 09:35
@omBratteng omBratteng requested review from capJavert and a team as code owners August 5, 2024 09:35
@omBratteng omBratteng changed the title feat: vordr on profile replies feat: vordr on profile replies and discussion feed Aug 5, 2024
capJavert
capJavert reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@capJavert capJavert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's add some tests for vordr on new queries.

@omBratteng omBratteng requested a review from capJavert August 6, 2024 13:29
@omBratteng
Copy link
Member Author

Added tests

capJavert
capJavert approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@capJavert capJavert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for adding tests for commentFeed

@omBratteng omBratteng merged commit 2155f20 into main Aug 6, 2024
8 checks passed
@omBratteng omBratteng deleted the AS-463-vordr branch August 6, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capJavert capJavert capJavert approved these changes

@idoshamun idoshamun Awaiting requested review from idoshamun

@rebelchris rebelchris Awaiting requested review from rebelchris rebelchris is a code owner automatically assigned from dailydotdev/web-team

@ilasw ilasw Awaiting requested review from ilasw ilasw is a code owner automatically assigned from dailydotdev/web-team

@sshanzel sshanzel Awaiting requested review from sshanzel sshanzel is a code owner automatically assigned from dailydotdev/web-team

@nensidosari nensidosari Awaiting requested review from nensidosari nensidosari is a code owner automatically assigned from dailydotdev/web-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omBratteng @capJavert