fix: escape post translated JSON (#2619)

dailydotdev · Jan 27, 2025 · cf0b9be · cf0b9be
1 parent f88f8ef
commit cf0b9be
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/__tests__/workers/postTranslated.ts b/__tests__/workers/postTranslated.ts
@@ -51,6 +51,28 @@ describe('postTranslated', () => {
     });
   });
 
+  it('should handle titles with special characters', async () => {
+    expect(
+      (await con.getRepository(Post).findOneByOrFail({ id: 'p1' })).translation,
+    ).toEqual({});
+
+    await expectSuccessfulTypedBackground(worker, {
+      id: 'p1',
+      language: ContentLanguage.German,
+      translations: {
+        title: `new title #"!#%&/()=?'"\`\\ƒ∂∞€€é∂ßä`,
+      },
+    });
+
+    expect(
+      (await con.getRepository(Post).findOneByOrFail({ id: 'p1' })).translation,
+    ).toEqual({
+      de: {
+        title: `new title #"!#%&/()=?'"\`\\ƒ∂∞€€é∂ßä`,
+      },
+    });
+  });
+
   it('should not update post translation if language is invalid', async () => {
     expect(
       (await con.getRepository(Post).findOneByOrFail({ id: 'p1' })).translation,

diff --git a/src/workers/postTranslated.ts b/src/workers/postTranslated.ts
@@ -22,11 +22,15 @@ export const postTranslated: TypedWorker<'kvasir.v1.post-translated'> = {
         .set({
           translation: () => `jsonb_set(
           translation,
-          '{${language}}',
-          '${JSON.stringify(translations)}'::jsonb,
+          :language,
+          :translations::jsonb,
           true
         )`,
         })
+        .setParameters({
+          language: [language],
+          translations: JSON.stringify(translations),
+        })
         .where('id = :id', { id })
         .execute();