Feat: bookmark search #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made a start on the search functionality
…r the search element
Improved search query, suggested bookmark query, and working unit test for basics
sshanzel
requested changes
Oct 11, 2021
idoshamun
requested changes
Oct 11, 2021
| const feedProps = useMemo<FeedProps<unknown>>(() => { | ||
| if (isSearchOn && searchQuery) { | ||
| return { | ||
| feedQueryKey: ['bookmarks', user?.id ?? 'anonymous', searchQuery], |
There was a problem hiding this comment.
Using the bookmarks while not logging in should not be possible.
If the user is not logged in maybe we should disable the query
There was a problem hiding this comment.
You actually can't get the bookmarks feed if not logged in.
The BookmarkFeedPage will redirect you if the token is refreshed.
I assumed this was a second fallback in the split second.
There was a problem hiding this comment.
Oh and fully tested locally yes
idoshamun
approved these changes
Oct 11, 2021
|
Waiting for @sshanzel to approve his ongoing PR and you can squash and merge. Just make to keep the commit convention :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to refactor the existing bookmark page
In the new version:
Bookmark page now has it's own layout system
Bookmark has a search menu
Bookmark has it's own search page (based on the layout)
Search adjusted to be more dynamic searchable (based on feed type)
Should be checked together with the PR on the API side.
DD-78 #done
Edit: Added the test cases