fix: plus gifter query error makes page slow #4179
Open
+15
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
ilasw
requested review from
rebelchris,
omBratteng,
capJavert,
sshanzel,
nensidosari and
AmarTrebinjac
capJavert
reviewed
Feb 12, 2025
| @@ -31,6 +31,7 @@ export const PlusPlus = ({ className }: PlusPlusProps): ReactElement => { | |||
| queryFn: getPlusGifterUser, | |||
| enabled: Boolean(user?.isPlus), | |||
| staleTime: StaleTime.Default, | |||
| retry: false, | |||
There was a problem hiding this comment.
I don't think we should disable retry but handle the error inside getPlusGifterUser, for example if ForbiddenError('User is not a gifted plus user') we catch it and return false from getPlusGifterUser
There was a problem hiding this comment.
you can check how to catch API error in useSourceIntegrationQuery
There was a problem hiding this comment.
Nice! Added retry again and moved with this solution ✔️
ilasw
changed the title
capJavert
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://fix-plus-checkout-loading.preview.app.daily.dev