feat: Plus CTA copy experiment #4173
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
ilasw
requested review from
rebelchris,
omBratteng,
capJavert,
sshanzel,
nensidosari and
AmarTrebinjac
| @@ -113,7 +116,7 @@ export const BlockedWords = (): ReactElement => { | |||
| }); | |||
| }} | |||
| > | |||
| upgrade to Plus | |||
| {plusCta} | |||
There was a problem hiding this comment.
I think we should lowercase the first letter from this variable since the replaced value did have a lowercased first letter which might mean this is a part of a whole sentence.
There was a problem hiding this comment.
Right, thanks for noticing! Updated ✔️
|
@sshanzel moved to conditional hook for better experiment tracking ✔️ |
| const { | ||
| value: { full: plusCta }, | ||
| } = useConditionalFeature({ | ||
| feature: featurePlusCtaCopy, | ||
| shouldEvaluate: !isPlus, | ||
| }); |
There was a problem hiding this comment.
I think it might be a good idea to introduce a hook that manages this (all usages). So that we can also check if isAuthReady is true as this can evaluate while the boot is being loaded.
Sorry for the last mile changes 🙏
There was a problem hiding this comment.
I can add a hook dedicated to this label but originally didn't want to over engineering this feature.
About the evaluation: I've checked the logic in hook and once shouldEvaluate value change it should rerun the query and check again (everything seems managed with useQuery and shouldEvaluate is both in queryKey and enabled).
There was a problem hiding this comment.
Yeah, what I mean is at on load, the value of isPlus is false then it would make the shouldEvaluate to true while the boot is still being fetched. And once it has turned true, the user is already enrolled even if we return it back to false with shouldEvaluate.
There was a problem hiding this comment.
I don't think having the hook would over-engineer the feature, especially since experiments are quite a mess to manage, and having a hook would make it easier to make changes across implementations. Also, I can help you refactor this if you are a bit occupied with high-priority tasks if you want 🙏
There was a problem hiding this comment.
If you are confident that the edge case won't unnecessarily enroll users (since experiments are expensive to run, hence a bit strict with enrollment), I'll trust your judgement so we can move on to merge the PR.
Changes
Experiment
Did you introduce any new experiments?
Name:
plus_cta_copyValue: JSON object with full/short properties
{ full: 'Upgrade to Plus', short: 'Upgrade' }Enrollment conditions:
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://mi-786-plus-copy-experiment.preview.app.daily.dev