feat: add kvasir support to smart title hook #4156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
capJavert
commented
Feb 6, 2025
Comment on lines
+46
to
+47
| queryKey: queryKey || getPostByIdKey(post?.id), | ||
| queryType: queryKey ? 'feed' : 'post', |
There was a problem hiding this comment.
We want to update translation for currently shown post that is passed as a prop to useSmartTitle so if we are in feed I use feed mode and else just single post
capJavert
commented
Feb 6, 2025
Comment on lines
+102
to
+104
| const [translateResult] = await fetchTranslations([post]); | ||
|
|
||
| client.setQueryData(key, translateResult?.value || post?.title); |
There was a problem hiding this comment.
Fetch from kvasir directly, it will return the correct one depending on the clickbait shield setting
capJavert
commented
Feb 6, 2025
| export const useTranslation: UseTranslation = ({ | ||
| queryKey, | ||
| queryType, | ||
| clickbaitShieldEnabled: clickbaitShieldEnabledProp, |
There was a problem hiding this comment.
to manually control which title we request
capJavert
requested review from
rebelchris,
omBratteng,
ilasw,
sshanzel,
nensidosari and
AmarTrebinjac
rebelchris
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://as-966-smart-title-hook-kvasir.preview.app.daily.dev