feat: multi squad post approval

[AmarTrebinjac]

Changes

Depends on this PR.

Not testable on preview before backend PR is merged

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://mi-635.preview.app.daily.dev

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
daily-webapp	✅ Ready (Inspect)	Visit Preview	Feb 6, 2025 0:50am

1 Skipped Deployment

Name	Status	Preview	Updated (UTC)
storybook	⬜️ Ignored (Inspect)		Feb 6, 2025 0:50am

[sshanzel]

We have to be careful with deployment. If we are updating the existing mutation, we must merge this PR at the same time the API is deployed. Otherwise, requests might fail.

[sshanzel]

Code-wise, looks amazing. Not much to add 💪

[rebelchris]

Code wise looks good to me.
Maybe once API is deployed we can do a e2e test on this branch before merging?

[capJavert]

@rebelchris It won't be possible to test since its not backward compatible dailydotdev/daily-api#2617 (comment) but if we want to test we can make it backward compatible on API.

[rebelchris]

@capJavert isnt out rule to have everything backward compatible on api.

I guess this all on webapp, but ideally so.
Im bit out of the loop why it is this way?

[capJavert]

I did not want to slow it down, but up to Amar how he wants to test it, agree it would be easier to have it backward compatible. We don't have to create separate query, we can do if sourceId { old logic } else { new logic }.

[AmarTrebinjac]

@capJavert isnt out rule to have everything backward compatible on api.

I guess this all on webapp, but ideally so. Im bit out of the loop why it is this way?

@capJavert I will re-add the param "sourceId" to make it backward compat, but just not use it in the backend. That way, it won't break anything.

Sounds good? 😄

[capJavert]

@AmarTrebinjac sounds good 👍