Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sidebar sections always visible #4103

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix: sidebar sections always visible #4103

merged 1 commit into from
Jan 23, 2025

Conversation

sshanzel
Copy link
Member

@sshanzel sshanzel commented Jan 23, 2025

Changes

  • Root cause: the sidebar when toggled to be minimized on desktop, then viewed the mobile version, the app hides the section itself.
  • By setting a parameter to say this should always be visible on mobile, the issue should be fixed.

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://fix-toggled-bookmarks.preview.app.daily.dev

Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Jan 23, 2025 3:02pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Jan 23, 2025 3:02pm

Copy link
Contributor

@ilasw ilasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@sshanzel sshanzel merged commit 56ecd9a into main Jan 23, 2025
10 checks passed
@sshanzel sshanzel deleted the fix-toggled-bookmarks branch January 23, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants