Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plus wrong discounted price #4081

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix: plus wrong discounted price #4081

merged 1 commit into from
Jan 20, 2025

Conversation

ilasw
Copy link
Contributor

@ilasw ilasw commented Jan 20, 2025

Changes

  • Lower price were evaluated based on formatted price (string), moved to unformatted (int) check.

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://mi-764-fix-plus-discount.preview.app.daily.dev

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Jan 20, 2025 9:30am
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Jan 20, 2025 9:30am

@ilasw ilasw merged commit 8c2043f into main Jan 20, 2025
10 checks passed
@ilasw ilasw deleted the MI-764-fix-plus-discount branch January 20, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants