Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: buttons spacing #4032

Merged
merged 23 commits into from
Jan 6, 2025
Merged

fix: buttons spacing #4032

merged 23 commits into from
Jan 6, 2025

Conversation

sshanzel
Copy link
Member

@sshanzel sshanzel commented Jan 2, 2025 •
edited
Loading

Changes

  • Fixes Collection List type.
  • Fixed Freeform List type.

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://fix-buttons-spacing.preview.app.daily.dev

@vercel Vercel
Copy link

vercel bot commented Jan 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Jan 6, 2025 1:02pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Jan 6, 2025 1:02pm

@sshanzel sshanzel marked this pull request as ready for review January 2, 2025 11:45
@sshanzel sshanzel requested a review from a team as a code owner January 2, 2025 11:45
@sshanzel sshanzel changed the title fix buttons spacing fix: buttons spacing Jan 2, 2025
@sshanzel sshanzel marked this pull request as draft January 2, 2025 23:25
@sshanzel
Copy link
Member Author

sshanzel commented Jan 3, 2025 •
edited
Loading

@dailydotdev/web-team should now be ready for review. To make it easier to review, I've created a confluence page to display each preview in the link below.

https://dailydotdev.atlassian.net/wiki/spaces/HAN/pages/1345683467/Feed+action+buttons+uniformity+testing

I do hope this experiment wins, and when we do the cleanup, it is probably about time we create a single Feed card component (one for list and one for grid) based on composition rather than creating for each type as it makes consistency a bit hard to maintain.

Basically, there will be three key components:

  • Header
  • Content
  • Footer (actions)

@sshanzel sshanzel marked this pull request as ready for review January 4, 2025 01:09
@sshanzel sshanzel merged commit 3ced5ed into main Jan 6, 2025
10 checks passed
@sshanzel sshanzel deleted the fix-buttons-spacing branch January 6, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmarTrebinjac AmarTrebinjac AmarTrebinjac approved these changes

@rebelchris rebelchris Awaiting requested review from rebelchris rebelchris is a code owner automatically assigned from dailydotdev/web-team

@omBratteng omBratteng Awaiting requested review from omBratteng omBratteng is a code owner automatically assigned from dailydotdev/web-team

@ilasw ilasw Awaiting requested review from ilasw ilasw is a code owner automatically assigned from dailydotdev/web-team

@capJavert capJavert Awaiting requested review from capJavert capJavert is a code owner automatically assigned from dailydotdev/web-team

@nensidosari nensidosari Awaiting requested review from nensidosari nensidosari is a code owner automatically assigned from dailydotdev/web-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sshanzel @AmarTrebinjac