feat: Add isAndroidApp to boot cache #4031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
AmarTrebinjac
requested review from
rebelchris,
omBratteng,
ilasw,
capJavert,
sshanzel and
nensidosari
idoshamun
reviewed
Jan 2, 2025
idoshamun
requested changes
Jan 2, 2025
idoshamun
reviewed
Jan 2, 2025
idoshamun
reviewed
Jan 2, 2025
idoshamun
approved these changes
Jan 2, 2025
rebelchris
approved these changes
Jan 3, 2025
| const { openModal } = useLazyModal(); | ||
| const { showPrompt } = usePrompt(); | ||
| const { showPlusSubscription, isPlus, logSubscriptionEvent } = | ||
| usePlusSubscription(); | ||
| const { value: appExperiment } = useConditionalFeature({ | ||
| feature: featureOnboardingAndroid, | ||
| shouldEvaluate: checkIsBrowser(UserAgent.Android) && !isAndroidApp(), | ||
| shouldEvaluate: checkIsBrowser(UserAgent.Android) && !isAndroidApp, |
There was a problem hiding this comment.
But this would still catch app even right due to webapp redirect?
There was a problem hiding this comment.
@rebelchris We store the isAndroidApp in the boot:local storage key now, so its persisted across visits. I tested on the chrome browser on my android phone in debug mode, and it did persist the value after redirect. I will test it on the app after merging to make sure it exhibits the same behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add check for android app in authcontext
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
MI-709 #done
Preview domain
https://mi-709.preview.app.daily.dev