Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrap the footer layout around history page #2916

Merged
merged 6 commits into from
Apr 4, 2024

Conversation

DragosIorgulescu
Copy link
Contributor

@DragosIorgulescu DragosIorgulescu commented Apr 3, 2024

Changes

Screenshot 2024-04-03 at 19 20 21

Events

N / A

Please make sure existing components are not breaking/affected by this PR

Manual Testing

On those affected packages:

  • Have you done sanity checks in the webapp?
  • Have you done sanity checks in the extension?
  • Does this not break anything in companion?

Did you test the modified components media queries?

  • MobileL (420px)
  • Tablet (656px)
  • Laptop (1020px)

Did you test on actual mobile devices?

  • iOS (Chrome and Safari)
  • Android

ref MI-266

Preview domain

https://mi-266-footer-nav-missing-on-history.preview.app.daily.dev

Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 3:43pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
storybook ⬜️ Ignored (Inspect) Apr 4, 2024 3:43pm

Copy link
Member

@sshanzel sshanzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

Copy link
Contributor

@rebelchris rebelchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small request to avoid a extra file 🙏

packages/webapp/pages/history.tsx Outdated Show resolved Hide resolved
@DragosIorgulescu
Copy link
Contributor Author

@rebelchris this is pending your approval to merge 🙏

Copy link
Contributor

@rebelchris rebelchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry for the delay all good!

@DragosIorgulescu DragosIorgulescu merged commit 0676b9b into main Apr 4, 2024
10 checks passed
@DragosIorgulescu DragosIorgulescu deleted the MI-266-footer-nav-missing-on-history branch April 4, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants