fix: new source and squad writing form issues #2895
Conversation
sshanzel
requested review from
rebelchris,
DragosIorgulescu,
omBratteng,
capJavert,
kopancek and
nensidosari
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
In your video the cancel goes to a completely different screen then where the user originated from. Edit: |
Yeah, noticed that too, but then I checked on prod and that is the current behavior.
I'm not sure it should be. Similar to the profile editing page, we wrapped it in a form.
This is just some feature flag turned off. |
|
@sshanzel Could you maybe open the first 2 questions for design/product (non blocking, but maybe good as follow up) |
| @@ -165,7 +173,41 @@ export function SquadDetails({ | |||
| }; | |||
|
|
|||
| return ( | |||
| <> | |||
| <ConditionalWrapper | |||
| condition={isMobile} | |||
There was a problem hiding this comment.
Should the condition not be isMobile && createMode?
There was a problem hiding this comment.
On Edit mode, there should be a "Save" button.
There was a problem hiding this comment.
But still in a form wrapper?
| <SquadDetails | ||
| className="p-8 pt-0" | ||
| form={form} | ||
| form={{ public: false }} |
There was a problem hiding this comment.
What does this setting do?
There was a problem hiding this comment.
Not really sure what happens inside, but I just noticed a local state above and doesn't seem to be changed. Instead I added this inline object over the unnecessary hook.
Not sure what's the motivation in making the Squad creation a popup since we are trying to move to pages, but sure, let me ask them. |
Changes
Screen.Recording.2024-04-01.at.11.10.20.PM.mov
Events
Did you introduce any new tracking events?
Don't forget to update the Analytics Taxonomy sheet
Log the new/changed events below:
Please make sure existing components are not breaking/affected by this PR
Manual Testing
On those affected packages:
Did you test the modified components media queries?
Did you test on actual mobile devices?
MI-251 #done