Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add back previous footer nav items on mobile #2885

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

DragosIorgulescu
Copy link
Contributor

@DragosIorgulescu DragosIorgulescu commented Mar 29, 2024

Changes

Screenshot 2024-03-29 at 08 19 45

Describe what this PR does

  • Short and concise, bullet points can help
  • Screenshots if applicable can also help

Events

Did you introduce any new tracking events?
Don't forget to update the Analytics Taxonomy sheet

Log the new/changed events below:

Type event_name value
Change/New event name extra: { ... }

Please make sure existing components are not breaking/affected by this PR

Manual Testing

On those affected packages:

  • Have you done sanity checks in the webapp?
  • Have you done sanity checks in the extension?
  • Does this not break anything in companion?

Did you test the modified components media queries?

  • MobileL (420px)
  • Tablet (656px)
  • Laptop (1020px)

Did you test on actual mobile devices?

  • iOS (Chrome and Safari)
  • Android

Preview domain

https://130-footer-mobile-behind-feature-flag.preview.app.daily.dev

- set the new navigation tabs behind a feature flag
Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 6:22am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
storybook ⬜️ Ignored (Inspect) Mar 29, 2024 6:22am

Copy link
Contributor

@nensidosari nensidosari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@DragosIorgulescu DragosIorgulescu merged commit 8f8be90 into main Mar 29, 2024
11 checks passed
@DragosIorgulescu DragosIorgulescu deleted the 130-footer-mobile-behind-feature-flag branch March 29, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants