Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: in forced tag selection we shouldn't auto update #2884

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

rebelchris
Copy link
Contributor

@rebelchris rebelchris commented Mar 28, 2024

Changes

Describe what this PR does

  • In forced tag selection we wan't to make sure users follow the picking of 5 tags before they can get enrolled in my feed alert.
  • Do note they actually get assigned the tags, but only get my feed trigger once they click the button

Events

Did you introduce any new tracking events?
Don't forget to update the Analytics Taxonomy sheet

Log the new/changed events below:

Type event_name value
Change/New event name extra: { ... }

Please make sure existing components are not breaking/affected by this PR

Manual Testing

On those affected packages:

  • Have you done sanity checks in the webapp?
  • Have you done sanity checks in the extension?
  • Does this not break anything in companion?

Did you test the modified components media queries?

  • MobileL (420px)
  • Tablet (656px)
  • Laptop (1020px)

Did you test on actual mobile devices?

  • iOS (Chrome and Safari)
  • Android

WT-{number} #done

Preview domain

https://fix-should-update-optional.preview.app.daily.dev

Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 4:46pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
storybook ⬜️ Ignored (Inspect) Mar 28, 2024 4:46pm

@rebelchris rebelchris merged commit 469225f into main Mar 28, 2024
11 checks passed
@rebelchris rebelchris deleted the fix-should-update-optional branch March 28, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants