refactor: move feed settings from MainFeedLayout to OnboardingFeedHeader #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omBratteng
requested review from
rebelchris,
DragosIorgulescu,
capJavert,
kopancek,
sshanzel and
nensidosari
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
rebelchris
approved these changes
Mar 28, 2024
nensidosari
approved these changes
Mar 28, 2024
capJavert
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Moves
useFeedSettingsfromMainFeedLayouttoOnboardingFeedHeader, as it does a queryFeedPreferencesquery in every feed right now when it is not needed.Preview domain
https://refactor-feedpreferences-query.preview.app.daily.dev