Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move the icon on chrome browser #2852

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Conversation

rebelchris
Copy link
Contributor

@rebelchris rebelchris commented Mar 23, 2024

Changes

Describe what this PR does

  • On chrome browser the icon has now changed to this filter icon, thus we needed to be more inline.
  • (Left FF/Right Chrome) (Edit after seeing my screenshot decided to change the copy and remove lock)
Screenshot 2024-03-23 at 15 50 32

Events

Did you introduce any new tracking events?
Don't forget to update the Analytics Taxonomy sheet

Log the new/changed events below:

Type event_name value
Change/New event name extra: { ... }

Please make sure existing components are not breaking/affected by this PR

Manual Testing

On those affected packages:

  • Have you done sanity checks in the webapp?
  • Have you done sanity checks in the extension?
  • Does this not break anything in companion?

Did you test the modified components media queries?

  • MobileL (420px)
  • Tablet (656px)
  • Laptop (1020px)

Did you test on actual mobile devices?

  • iOS (Chrome and Safari)
  • Android

AS-205 #done

Preview domain

https://as-205-chrome-notification-icon.preview.app.daily.dev

@rebelchris rebelchris requested a review from a team as a code owner March 23, 2024 13:52
Copy link

vercel bot commented Mar 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 6:13am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
storybook ⬜️ Ignored (Inspect) Mar 25, 2024 6:13am

@rebelchris rebelchris merged commit 6643d9f into main Mar 25, 2024
3 of 6 checks passed
@rebelchris rebelchris deleted the AS-205-chrome-notification-icon branch March 25, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants