Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export getHonoContext #884

Merged
merged 2 commits into from
Sep 16, 2024
Merged

feat: export getHonoContext #884

merged 2 commits into from
Sep 16, 2024

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Sep 16, 2024

following #852, this should be more explicit. Still unstable, but less experimental.

Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Sep 16, 2024 5:45am

Copy link

codesandbox-ci bot commented Sep 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@rmarscher rmarscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Being able to access this from RSC in an actual server environment provides a lot of flexibility and resolves #827 for Cloudflare usage.

@dai-shi dai-shi marked this pull request as ready for review September 16, 2024 05:27
@dai-shi dai-shi merged commit 232a3a5 into main Sep 16, 2024
28 checks passed
@dai-shi dai-shi deleted the expose/get-hono-context branch September 16, 2024 06:49
dai-shi added a commit that referenced this pull request Sep 19, 2024
Instead of #852 and #884, let's use Hono's `getContext` instead.
dai-shi added a commit that referenced this pull request Sep 28, 2024
at least for now. this reverts #891 and re-introduce #852 and #884.

#911 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: An API for accessing platform specific data/information/APIs (e.g. the Cloudflare ones)
2 participants