Instructions on how to enable the React Compiler in a Waku pro… #857
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
docs/guides/react-compiler.mdx
Outdated
| }); | ||
| ``` | ||
|
|
||
| For a practical demonstration, visit this [StackBlitz demo](https://stackblitz.com/edit/github-ukt9tm?file=vite.config.ts) which provides a real-world example of the configuration in action. |
There was a problem hiding this comment.
I've updated the demo.
| For a practical demonstration, visit this [StackBlitz demo](https://stackblitz.com/edit/github-ukt9tm?file=vite.config.ts) which provides a real-world example of the configuration in action. | |
| For a practical demonstration, visit this [StackBlitz demo](https://stackblitz.com/edit/github-h4uxwo?file=vite.config.ts) which provides a real-world example of the configuration in action. |
As I tried, removing "annotation" will cause errors. Can you please try it? I guess we should add it in the instruction above. What do you think? Do you think we can recommend it even with "annotation"?
There was a problem hiding this comment.
I believe we shouldn't add this restriction because if we add an "annotation", users will need add the "use memo" directive manually
I found the error is Error: __vite_ssr_import_1__.c is not a function, actually I encountered this error when I implement react compiler feature, I can try to fix it issue
There was a problem hiding this comment.
I can try to fix it issue
That will be great.
There was a problem hiding this comment.
This issue occurs when I pass react compiler config in viteReact called by createRscViteServer. So in my implementation I only pass react compiler config in viteReact called by createMainViteServer
There was a problem hiding this comment.
Do we not need react compiler for server files?
My plan is to allow customizing vite config for each server in v0.22.0. Give me more time.
There was a problem hiding this comment.
Actually, I noticed the change isn't breaking much, so I decided to work on it during v0.21.*.
Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
|
let's revisit this after v0.22 is finished. |
Background: #853