Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use server action from client modules #714

Merged
merged 10 commits into from
May 21, 2024
Merged

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented May 17, 2024

close #403

  • dev
  • prd

Remaining

  • refactor
  • tests
  • docs

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview May 21, 2024 0:41am

Copy link

codesandbox-ci bot commented May 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi dai-shi mentioned this pull request May 20, 2024
dai-shi added a commit that referenced this pull request May 20, 2024
follow up #708 which wasn't enough. related: #714
@dai-shi dai-shi marked this pull request as ready for review May 20, 2024 14:18
@dai-shi dai-shi mentioned this pull request May 20, 2024
@dai-shi dai-shi changed the title feat: use server action from client feat: use server action from client modules May 20, 2024
@dai-shi dai-shi merged commit 84941a4 into main May 21, 2024
28 checks passed
@dai-shi dai-shi deleted the directly-use-server branch May 21, 2024 02:36
Copy link
Contributor

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome

},
build: {
write: false,
ssr: true,
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on second look, i'm not sure if this should be "ssr". we will need to revisit this double build anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow import server action in client side
2 participants